Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Rearrange directory structure to use /vendor folder? #225

Closed
nathany opened this issue Jun 11, 2015 · 8 comments
Closed

Rearrange directory structure to use /vendor folder? #225

nathany opened this issue Jun 11, 2015 · 8 comments

Comments

@nathany
Copy link

nathany commented Jun 11, 2015

I'm curious what the plan is in light of this proposal to add a -vendor flag to the go tool?
https://groups.google.com/d/msg/golang-dev/74zjMON9glU/4lWCRDCRZg0J

related #127

@kr
Copy link
Member

kr commented Jun 11, 2015

The very rough plan is to change godep to use the new /vendor/ directory layout, possibly guarded by a command line flag. Then if the go tool -vendor flag is successful, godep will use that layout by default and remove import path rewriting (the -r flag) entirely.

@nathany
Copy link
Author

nathany commented Jun 11, 2015

Do you think it makes sense to keep modifying godep, or perhaps the directory change is a good time to come up with a tool under a new name (possibly using a lot of the same code)?

@kr
Copy link
Member

kr commented Jun 19, 2015

I'm going to help update godep to support the new format, but I won't have the time it would take to devote to a whole new tool.

@kr
Copy link
Member

kr commented Jun 19, 2015

However, that certainly shouldn't stop anyone else if they want to try that route. Godep is open source, so if its code would help they are welcome to use it!

@ngrilly
Copy link

ngrilly commented Jun 19, 2015

@nathany What would be the purpose of "coming up with a tool under a new name"?

@nathany
Copy link
Author

nathany commented Jun 19, 2015

@ngrilly It just seems a little awkward to support multiple ways of doing it from a single tool, as a user.

But eventually godep will get there (once -r is gone and only one directory structure is supported, at least for new projects).

@freeformz
Copy link

See #240. I'm going to close this and urge anyone with input to discuss there. Thanks!

freeformz pushed a commit that referenced this issue Jul 13, 2015
The GO15VENDOREXPERIMENT env variable is how the vendor experiment is
enabled and we should respect that and use it when the user has it set.

Reviewers: @kr

/cc #172, #184, #240, #225
@Dmitriy11111
Copy link

d to r/c/Godeps/_workspace/src/d and copy r/p to r/c/Godeps/_workspace/src/r/p. Change any import statement in r/c and the tree rooted at r/c from "d" to “r/c/Godeps/_workspace/src/d” and from “r/p” to “r/c/Godeps/_workspace/src/r/p”. Note that import statements in r/p remain unchanged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants