Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Future plans for GoVersion #297

Closed
jtarchie opened this issue Oct 20, 2015 · 4 comments
Closed

Future plans for GoVersion #297

jtarchie opened this issue Oct 20, 2015 · 4 comments

Comments

@jtarchie
Copy link

Are there plans for godeps to use GoVersion other than just recording it?

We're asking because we (Cloud Foundry buildpacks team) are planning to allow users to specify their go version like

{
   "GoVersion": "go1.4.*"
}

This will allow a user to get the latest patch version of go during staging, instead of getting a staging error due to unsupported versions. However, if there are plans for godeps to use this field, our use could break. Thanks for any info!

@freeformz
Copy link

It's used in the heroku buildpack to determine what version of go should be used to compile the provided code. I have thought about doing something similar in the heroku buildpack (where '1.4.*' would mean the latest patch revision of 1.4'. Beyond that I consider it an optional field as godep really shouldn't be involved with compiling code in any way in the long term. But also note that godep will update that value if you save and are running a newer version.

@mavenraven
Copy link

Thanks for the info. The CF buildpacks are downstream of the Heroku ones, so it might be possible for us to do this in the upstream repo and send you a PR, if you're interested.

@freeformz
Copy link

That would be great!

@jtarchie
Copy link
Author

@freeformz, can we clarify about the wildcard. We'd like to support it for patch level, not minor/major. I'll reopen this on the buildpack's issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants