Merge pull request #168 from jenshnielsen/fix_mypy

Drop support for python 3.6 and support typechecking with qcodes 0.21.0
toolsforexperiments · Dec 22, 2020 · 07f67b8 · 07f67b8
2 parents 98aa8ab + 0fa6e86
commit 07f67b8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.6, 3.7, 3.8, 3.9]
+        python-version: [3.7, 3.8, 3.9]
     env:
       DISPLAY: ':99.0'
 

diff --git a/plottr/node/scaleunits.py b/plottr/node/scaleunits.py
@@ -2,7 +2,7 @@
 from typing import Optional, Dict
 
 try:
-    from qcodes.utils.plotting import find_scale_and_prefix  #  type: ignore[attr-defined]
+    from qcodes.utils.plotting import find_scale_and_prefix
 except ImportError:
     # fallback for qcodes < 0.21
     from plottr.utils.find_scale_and_prefix import find_scale_and_prefix

diff --git a/setup.py b/setup.py
@@ -34,12 +34,11 @@
         'Intended Audience :: Science/Research',
         'License :: OSI Approved :: MIT License',
         'Programming Language :: Python :: 3 :: Only',
-        'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
         'Programming Language :: Python :: 3.8',
         'Topic :: Scientific/Engineering'
     ],
-    python_requires='>=3.6',
+    python_requires='>=3.7',
     extras_require={'PyQt5': "PyQt5", "PySide2": "PySide2"},
     entry_points={
         "console_scripts": [