New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new notification type: admin.sign_up #305
Comments
Just to confirm: these notifications already show correctly. We don't need to change anything there. Just the ability to tune them out so the rest of the stuff is better accessible. |
If there are any pointers, I might be able to PR this. Edit: Ok I tried reading some code and probably not, sorry... looks like React has changed A TON in recent years... |
I think it is mainly because I am not an professional engineer thus my code is not that structured nor readable.. Anyways, this is where we can add a new type for notifications tab filtering, https://github.com/tooot-app/app/blob/main/src/screens/Actions/NotificationsFilter.tsx#L40-L54. Normally I would expect the official API documentation to be updated to reflect this change, unfortunately the core team is not doing so anymore, may be because they prioritise their first-party apps which is a pity. I have to dig into their updates in order to know what has been updated. I would be able to get some time in the upcoming few days to update this if you could not figure out where to add stuff. |
I think that you've got this app here and a bunch of users for it shows you absolutely are a "professional" developer. It's just that I come from a time when React was all about ES6 class based components. That paradigm was my favorite! I digress... but yeah, I probably wouldn't be able to PR this. Not in any meaningful way. But I'll poke around and see if something comes of it. |
Mastodon v3.5.0 added a new notification type:
admin.sign_up
:It would be nice if this can be supported in the notification filters so I can remove them from the notifications tab entirely. Otherwise it's crowded out and I don't get much use out of the tab.
The text was updated successfully, but these errors were encountered: