Skip to content

Commit

Permalink
fix: #1
Browse files Browse the repository at this point in the history
  • Loading branch information
toorop committed Dec 11, 2015
1 parent 229ddd5 commit fa48964
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions dkim.go
Expand Up @@ -83,7 +83,7 @@ type SigOptions struct {
CopiedHeaderFields []string
}

// NewSigOption returns new sigoption with some defaults value
// NewSigOptions returns new sigoption with some defaults value
func NewSigOptions() SigOptions {
return SigOptions{
Version: 1,
Expand Down Expand Up @@ -196,7 +196,7 @@ func Sign(email *[]byte, options SigOptions) error {
return nil
}

// verify verifies an email an return
// Verify verifies an email an return
// state: SUCCESS or PERMFAIL or TEMPFAIL, TESTINGSUCCESS, TESTINGPERMFAIL
// TESTINGTEMPFAIL or NOTSIGNED
// error: if an error occurs during verification
Expand All @@ -206,15 +206,16 @@ func Verify(email *[]byte) (verifyOutput, error) {
if err != nil {
if err == ErrDkimHeaderNotFound {
return NOTSIGNED, ErrDkimHeaderNotFound
} else {
return PERMFAIL, err
}
return PERMFAIL, err
}

// we do not set query method because if it's others, validation failed earlier
pubKey, verifyOutputOnError, err := newPubKeyFromDnsTxt(dkimHeader.Selector, dkimHeader.Domain)
if err != nil {
return getVerifyOutput(verifyOutputOnError, err, pubKey.FlagTesting)
// fix https://github.com/toorop/go-dkim/issues/1
//return getVerifyOutput(verifyOutputOnError, err, pubKey.FlagTesting)
return verifyOutputOnError, err
}

// Normalize
Expand Down

0 comments on commit fa48964

Please sign in to comment.