Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch global should be a "namespace" #34

Closed
TooTallNate opened this issue Sep 30, 2023 · 0 comments · Fixed by #70
Closed

Switch global should be a "namespace" #34

TooTallNate opened this issue Sep 30, 2023 · 0 comments · Fixed by #70

Comments

@TooTallNate
Copy link
Owner

TooTallNate commented Sep 30, 2023 •
edited

Currently, the Switch global is a variable that is an instance of the SwitchClass class.

Instead, Switch should be a singleton module that is defined as:

import * as Switch from './switch';

export type * as Switch from './switch';
def('Switch', Switch);

This way, it will be a namespace at the TypeScript and TypeDoc level, and we get rid of SwitchClass entirely.
@TooTallNate TooTallNate changed the title Convert Switch global into a "namespace" Switch global should be a "namespace" Dec 16, 2023
TooTallNate added a commit that referenced this issue Dec 16, 2023
@TooTallNate
Convert Switch global into a "namespace"
bec450a 
Closes #34.
@TooTallNate TooTallNate mentioned this issue Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert Switch global into a "namespace" TooTallNate/nx.js
1 participant
@TooTallNate