Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate addData* #88

Closed
hypesystem opened this issue Jan 23, 2015 · 2 comments · Fixed by #90
Closed

Deprecate addData* #88

hypesystem opened this issue Jan 23, 2015 · 2 comments · Fixed by #90
Labels
enhancement
Milestone
v0.10

Comments

@hypesystem
Copy link
Collaborator

Deprecate Message#addDataWithObject and Message#addDataWithKeyValue.

Both of these are now covered by Message#addData (and will be removed in v1).

They should probably print something to console.warn or something.
@hypesystem hypesystem added this to the v0.10 milestone Jan 23, 2015
@hypesystem hypesystem mentioned this issue Jan 26, 2015
Merged
@ToothlessGear
Copy link
Owner

Additionally I'd suggest to write in the README that those are deprecated, or remove them entirely to avoid more confusion as I've read in the other issue #70

@hypesystem
Copy link
Collaborator Author

Added it to the changelog. Seeing as they aren't referenced anywhere else in the README, I think we are safe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Deprecate add data with ToothlessGear/node-gcm
2 participants
@hypesystem @ToothlessGear