Skip to content

Commit

Permalink
Add blurhash to preview cards (#13984)
Browse files Browse the repository at this point in the history
Fixes #13001
  • Loading branch information
ClearlyClaire committed Jun 5, 2020
1 parent a415f44 commit 346d9b3
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 5 deletions.
9 changes: 8 additions & 1 deletion app/models/preview_card.rb
Expand Up @@ -23,19 +23,25 @@
# updated_at :datetime not null
# embed_url :string default(""), not null
# image_storage_schema_version :integer
# blurhash :string
#

class PreviewCard < ApplicationRecord
IMAGE_MIME_TYPES = ['image/jpeg', 'image/png', 'image/gif'].freeze
LIMIT = 1.megabytes

BLURHASH_OPTIONS = {
x_comp: 4,
y_comp: 4,
}.freeze

self.inheritance_column = false

enum type: [:link, :photo, :video, :rich]

has_and_belongs_to_many :statuses

has_attached_file :image, styles: ->(f) { image_styles(f) }, convert_options: { all: '-quality 80 -strip' }
has_attached_file :image, processors: [:thumbnail, :blurhash_transcoder], styles: ->(f) { image_styles(f) }, convert_options: { all: '-quality 80 -strip' }

include Attachmentable

Expand Down Expand Up @@ -72,6 +78,7 @@ def image_styles(f)
geometry: '400x400>',
file_geometry_parser: FastGeometryParser,
convert_options: '-coalesce -strip',
blurhash: BLURHASH_OPTIONS,
},
}

Expand Down
2 changes: 1 addition & 1 deletion app/serializers/rest/preview_card_serializer.rb
Expand Up @@ -6,7 +6,7 @@ class REST::PreviewCardSerializer < ActiveModel::Serializer
attributes :url, :title, :description, :type,
:author_name, :author_url, :provider_name,
:provider_url, :html, :width, :height,
:image, :embed_url
:image, :embed_url, :blurhash

def image
object.image? ? full_asset_url(object.image.url(:original)) : nil
Expand Down
5 changes: 5 additions & 0 deletions db/migrate/20200605155027_add_blurhash_to_preview_cards.rb
@@ -0,0 +1,5 @@
class AddBlurhashToPreviewCards < ActiveRecord::Migration[5.2]
def change
add_column :preview_cards, :blurhash, :string
end
end
4 changes: 2 additions & 2 deletions db/schema.rb
Expand Up @@ -10,8 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2020_06_01_222558) do

ActiveRecord::Schema.define(version: 2020_06_05_155027) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"

Expand Down Expand Up @@ -648,6 +647,7 @@
t.datetime "updated_at", null: false
t.string "embed_url", default: "", null: false
t.integer "image_storage_schema_version"
t.string "blurhash"
t.index ["url"], name: "index_preview_cards_on_url", unique: true
end

Expand Down
2 changes: 1 addition & 1 deletion lib/paperclip/blurhash_transcoder.rb
Expand Up @@ -3,7 +3,7 @@
module Paperclip
class BlurhashTranscoder < Paperclip::Processor
def make
return @file unless options[:style] == :small
return @file unless options[:style] == :small || options[:blurhash]

pixels = convert(':source RGB:-', source: File.expand_path(@file.path)).unpack('C*')
geometry = options.fetch(:file_geometry_parser).from_file(@file)
Expand Down

0 comments on commit 346d9b3

Please sign in to comment.