Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityPub: outbox pages contain unordered sets of activities #3438

Closed
1 of 2 tasks
puckipedia opened this issue May 30, 2017 · 2 comments
Closed
1 of 2 tasks

ActivityPub: outbox pages contain unordered sets of activities #3438

puckipedia opened this issue May 30, 2017 · 2 comments

Comments

@puckipedia
Copy link
Contributor

puckipedia commented May 30, 2017 •
edited

According to the spec, items is a set, while orderedItems is an (ordered) list. This is due to the JSON-LD serialization of AS2: JSON-LD defaults to unordered sets. When using list, some clients may not be able to show the Activities in the right order. To fix this, the OrderedCollectionPages should contain orderedItems instead of items.

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@evanminto
Copy link
Contributor

evanminto commented Jun 7, 2017 •
edited

I'm already working on fixing this one. I made some mistakes in implementing the spec.

EDIT: Misunderstood. I fixed a different paging issue. I'll fix this next chance I get.

@Gargron
Copy link
Member

Gargron commented Jun 24, 2017

Gonna link this up with #3844

@Gargron Gargron mentioned this issue Jul 14, 2017
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gargron @puckipedia @evanminto