Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet URIs are not clickable #6248

Closed
1 of 2 tasks
SoniEx2 opened this issue Jan 12, 2018 · 10 comments
Closed
1 of 2 tasks

Magnet URIs are not clickable #6248

SoniEx2 opened this issue Jan 12, 2018 · 10 comments

Comments

@SoniEx2
Copy link

SoniEx2 commented Jan 12, 2018

URIs have existed for a while. Granted, they are newer than URLs. But they don't seem to be supported in even relatively recent software such as mastodon.

This strikes me as really odd. URIs should really be supported in mastodon. I wanted to share a pic but the magnet URI wasn't clickable. This is really important when trying to avoid selling yourself to imgur and the like.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@moggers87
Copy link

@SoniEx2 could you change the title of this issue to be a bit more descriptive? Something like "Magnet URIs are not clickable"

@voronoipotato
Copy link

Yes clickable magnet-uri would be a good first step, peertube is probably not long from being released and will likely try to federate with mastodon by sharing the magnet links. We can either use webtorrent to directly download the video and images via p2p or I think more conservatively and with less effort just make the magnet link clickable. Can you please rename this issue @SoniEx2 it currently has a very ambiguous and confusing name. There are over 800 other issues.

@voronoipotato
Copy link

Chocobozzz/PeerTube#183 here you can see they're already trying to federate with mastodon. We should probably communicate with them once they get closer to release to make sure that everything is going smoothly.

@sorin-davidoi sorin-davidoi changed the title URI is the new IPv6 Magnet URIs are not clickable Jan 12, 2018
@nightpool
Copy link
Member

We already have worked with peertube on federation. Magnet URIs are not clickable because there is very little client software that supports it. Mastodon only supports two types of clickable links, http and https. See #6072 for more information

@voronoipotato
Copy link

voronoipotato commented Jan 12, 2018

webtorrent uses it so there would be no need for client software. it could be done entirely clientside. This is how peertube's implementation works. I dont think implementing federating with magnet hosts in such a way that it only works with one implementation is wise. After all what's to say another activitypub federation doesn't pop up that uses webtorrents for large images.

@SoniEx2
Copy link
Author

SoniEx2 commented Jan 12, 2018

I use magnet URIs myself. But honestly I think you should just parse all URIs.

URI has been specced since 1998/2005 (depending on how you wanna consider it), IPv6 since 1996, URL since 1994 and IPv4 since 1981.

We shouldn't make the same mistakes as IPv4/IPv6 with URIs.

@voronoipotato
Copy link

all URIs? even ../../../resource.txt

@nightpool
Copy link
Member

nightpool commented Jan 13, 2018

Again, two acknowledge the two completely different issues that are being talked about here:

  • Mastodon currently only turns plaintext IRIs in LOCAL status into links if they have a protocol of https or http. This is due to the twitter library, as discussed in the issue I linked upthread. It has nothing to do with federation, which parses links from html, not plaintext.

  • Mastodon will cache locally assets that use the http or https protocol. This is because Mastodon is a microblogging service, and it's ill-suited for transferring large files or videos. PeerTube federation is accomplished by showing users a link to the source of the activity (it's page on the originating peertube instance) so users can easily click through and watch the video if they're interested. This is analogous to, e.g. how YouTube and twitter crossposting works and it matches the goals of the software well while still being fully open and compatible not just with peertube, but with any activitypub compliant software.

Let's make sure to keep these two topics separate.

@SoniEx2
Copy link
Author

SoniEx2 commented Jan 13, 2018

@voronoipotato
Copy link

Anyway this is still actually a good idea and someone should submit a pull request.

@Gargron Gargron closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants