Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No card on local URL. Card appear on remote URL. #7224

Closed
1 of 2 tasks
luzi82 opened this issue Apr 22, 2018 · 2 comments
Closed
1 of 2 tasks

No card on local URL. Card appear on remote URL. #7224

luzi82 opened this issue Apr 22, 2018 · 2 comments

Comments

@luzi82
Copy link
Contributor

luzi82 commented Apr 22, 2018

2 cases:

Case A: Post a local status URL. Result: no card.
https://mastodon.social/@luzi82/99901586977699696

Case B: Post an URL of status in other instance. Result: Card appear.
https://mastodon.social/@luzi82/99901950805132861

It seems related to the bad_url function in fetch_link_card_service.rb . And it seems it is "designed" to ignore local URL. But I dont know why. ( If you hate mentioning other status, you may also need to bad_url all the remote instances. But I dont agree doing this. Mentioning is good. )

Related stuff:
#2572 450ad43 1efda1c f8fe394
https://github.com/tootsuite/mastodon/blob/master/app/services/fetch_link_card_service.rb


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@mal0ki
Copy link

mal0ki commented May 1, 2018

This is partially intentional, and because we don't want quote toots to be a thing (as it's partially used in a very negative manner on some other platforms).

However, it doesn't display on the "Web-UI" but rather only when you go to the actual page of the toot (which not a lot of people do).

See photos below:

image

image

@luzi82
Copy link
Contributor Author

luzi82 commented May 3, 2018

If it is intentional then it is fine.
I may try to disable that filter in my own instance.
I wish there is no critical bug.

Moreover, I can see preview card in your reply. I guess it need time to load.

screenshot_2018-05-03_23-05-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants