Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Mode: Change mastodon.dev to something that works #8684

Closed
1 of 2 tasks
trev-dev opened this issue Sep 13, 2018 · 11 comments
Closed
1 of 2 tasks

Dev Mode: Change mastodon.dev to something that works #8684

trev-dev opened this issue Sep 13, 2018 · 11 comments

Comments

@trev-dev
Copy link
Contributor

trev-dev commented Sep 13, 2018

I have a local vagrant setup where I changed the hostname to mastodon.local so that my vagrant dev server would actually load. Google has done something crappy with .dev sites that breaks them on local machines. However, the mastodon server is still serving static assets from mastodon.dev.

I tried using ag/ripgrep to see if I could find any other configurations that set the dev server's dns to mastodon.dev, I couldn't find anything.

Is there any chance I may get some guidance with changing the mastodon vagrant dev dns or perhaps see the default changed in a PR?


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@trev-dev
Copy link
Contributor Author

I'm gussing my ag/grep overlooked hidden files. I was able to change the dev server dns by modifying it in .vagrant.env - probably something someone more experienced with vagrant would know.

P.S. thank you so much for Mastodon. I enjoy making contributions to my local instance! I'm gonna leave this open, though. I don't feel like mastodon.dev is a sane default for Vagrant. I'll send a PR later.

@Gargron
Copy link
Member

Gargron commented Sep 13, 2018

What would you suggest?

@nightpool
Copy link
Member

nightpool commented Sep 13, 2018 via email

@trev-dev
Copy link
Contributor Author

@nightpool Awesome! I'm not sure the problem happens everywhere. However, I can reinforce my argument with the following:
https://stackoverflow.com/questions/47809632/i-can-no-longer-access-my-local-development-dev-websites-in-chrome-http-is
https://www.theregister.co.uk/2017/11/29/google_dev_network/
https://medium.engineering/use-a-dev-domain-not-anymore-95219778e6fd

@Gargron I was going to go with .local or .test. I've got the .vagrant.env and the Vagrantfile situation figured out. I'm just not sure as to where the default dev admin account is created within the Ruby backend as I'm not strong with Ruby. If you give me a push, I'd be happy to do the work.

Thanks for your responses!

@nightpool
Copy link
Member

nightpool commented Sep 14, 2018 via email

@justinmayer
Copy link

@nightpool: If heading in that direction, have a look at mkcert.

@Gargron
Copy link
Member

Gargron commented Sep 14, 2018

Hold on, is there no better option than to use SSL on a local machine? That seems kinda pointless and overly complicated. Why do we even need a TLD, won't it work with localhost?

@justinmayer
Copy link

@Gargron: TLS does indeed work with localhost, and I personally haven't found using TLS for local development to be overly complicated. As for why one would want to use TLS on a local workstation, one reason is that it is required for WebAuthn (successor to U2F), support for which I hope will someday land in Mastodon. 😁

@nightpool
Copy link
Member

nightpool commented Sep 15, 2018 via email

@trev-dev
Copy link
Contributor Author

trev-dev commented Sep 15, 2018

Literally just changing the domain name in the 2 vagrant config files and re-provisioning fixes the issue. I'll send a PR later tonight what'll include some commented out options to increase vagrant performance as well while I'm at it.

@trev-dev
Copy link
Contributor Author

Pull request sent.
#8706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants