Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct opt-out showing application #10086

Merged
merged 3 commits into from Feb 20, 2019

Conversation

@hinaloe
Copy link
Contributor

commented Feb 20, 2019

in #9994, api response of status was not correct opted-out without save settings. (/@user/:status is correct.)

refs #9994
@ykzts
ykzts approved these changes Feb 20, 2019
@Gargron

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

I am confused. User#shows_application? calls the wrong variable?

hinaloe added 2 commits Feb 20, 2019
This reverts commit 0e9bb70.
@hinaloe

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

Oh, that right. User#shows_application? looks call wrong var.

I reverted change of serializer and fix User model.

@Gargron Gargron merged commit 4340d33 into tootsuite:master Feb 20, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* correct opt-out showing application

refs tootsuite#9994

* Revert "correct opt-out showing application"

This reverts commit 0e9bb70.

* User#shows_application? calls wrong value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.