Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preferences API so apps can share basic behaviours #10109

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

commented Feb 24, 2019

Resolve #9821

GET /api/v1/preferences example output:

{
  "posting:default:visibility": "public",
  "posting:default:sensitive": false,
  "posting:default:language": null,
  "reading:expand:media": "default",
  "reading:expand:spoilers": false
}
@ykzts

ykzts approved these changes Mar 5, 2019

@ykzts

This comment has been minimized.

Copy link
Collaborator

commented Mar 5, 2019

oops. this PR was draft

@Gargron

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

@Tak @connyduck Is this sufficient?

@Gargron Gargron marked this pull request as ready for review Mar 5, 2019

@Tak

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@Gargron Sorry, it's not clear to me from the diff - does this also allow apps to write these preferences?

A minor comment on the output format - if the keys are meant to be hierarchical, why not represent them that way in the json?

"posting": {
  "default": {
    "visibility": "public",
    "sensitive": false,
    "language": null
  }
},
"reading": { //...```

@Gargron Gargron merged commit d94e21f into master Mar 15, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-preferences-api branch Mar 15, 2019

@Tak

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Cool, good discussion.

enewhuis added a commit to BrazosCC/mastodon that referenced this pull request Mar 15, 2019

@digitalcircuit digitalcircuit referenced this pull request May 10, 2019

Open

Add option to disable CWs #642

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.