Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mention processing for unknwon accounts on incoming ActivityPub Notes #10125

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@ThibG
Copy link
Collaborator

ThibG commented Feb 27, 2019

::FetchRemoteAccountService is not ActivityPub::FetchRemoteAccountService,
its second argument is the pre-fetched body. Passing id: false actually passed
a Hash as the prefetched body, instead of properly resolving unknown remote
accounts.

Fix mention processing for unknwon accounts on incoming ActivityPub N…
…otes

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Feb 27, 2019

Another solution would be to revert ef69c65 I guess. I'm not sure exactly what it solves?

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Feb 27, 2019

I'm not sure exactly what it solves?

href is not id, therefore it's not necessarily the verbatim URI of the account. At least that's what I think it was about. Or maybe I was getting errors about an unknown constant so I fixed it but picked the wrong namespace?

@Gargron Gargron merged commit 9edab46 into tootsuite:master Feb 27, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request Mar 5, 2019

Fix mention processing for unknwon accounts on incoming ActivityPub N…
…otes (#10125)

`::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`,
its second argument is the pre-fetched body. Passing `id: false` actually passed
a `Hash` as the prefetched body, instead of properly resolving unknown remote
accounts.

@ThibG ThibG deleted the ThibG:fixes/create-mention-resolving branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.