Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relationship manager UI #10268

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

Gargron commented Mar 14, 2019

image

Ultimately, the authorized followers page, listing domains of all followers, was not very useful. On the other hand, removing more than one follower through the web UI was very involved, because it requires a click-through to each profile, switching from the list of accounts and back.

The new "Follows and followers" page is more mature. It lists who you follow, or all followers individually, while letting them be filtered (e.g. show only mutuals, show people who have moved accounts), and more importantly, allowing batch actions to be applied. You can select multiple followers and remove them at once. Preserving the old functionality, you can also select one or more followers, and block the entire domains that they are from. You can also batch unfollow who you were following.

It also shows you when your follows/followers were last active.

@Gargron Gargron force-pushed the feature-manage-followers branch 3 times, most recently from 658a132 to 499815c Mar 14, 2019

@Gargron Gargron marked this pull request as ready for review Mar 15, 2019

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Mar 15, 2019

Looks good! I think not being able to search or remove followers from a particular domain is an important regression, though.

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Mar 15, 2019

If you select a follower from a domain and click the second batch button, it will block the entire domain of that follower. Also, it was hard to find a specific domain in the list before, too, so I wouldn't call it a regression. I wanted to add a search form, however, we don't have ready-made components for search for end-users. We have the admin design but it's a bit clunky...

On the other hand, I just noticed I am not putting filter params relationship, status and by_domain into the form, which is a mistake that will affect redirects to the right page.

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Mar 15, 2019

Oh, I did not notice the “Remove all followers from the selected domains” thing. This is suboptimal but it does cover that functionality, so why not.

As for a search form, I believe I had made a PR for that ;)

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Mar 15, 2019

Yes, I didn't merge it because I was planning to do this. And as I mentioned:

We have the admin design but it's a bit clunky...

I.e. my concern is that the input and search buttons interrupt the page flow in a way that may be confusing to non-technical users, and it's not super pretty. I would expect the search to look more like what we have in the list editing modal in the web UI, or the search form in the web UI, but of course, it's complicated because that's in React, and this is outside React.

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Mar 15, 2019

The only real change between what we have for admin views and what we have in React is that the page gets reloaded, right?

@Gargron Gargron force-pushed the feature-manage-followers branch from 499815c to f877955 Mar 16, 2019

@Gargron Gargron changed the title Change authorized follower domains UI into follower management UI Add relationship manager UI Mar 16, 2019

@Gargron Gargron force-pushed the feature-manage-followers branch from f877955 to 90bdb72 Mar 16, 2019

@Gargron Gargron force-pushed the feature-manage-followers branch from 90bdb72 to 16b2caa Mar 16, 2019

@Gargron Gargron requested a review from ykzts Mar 16, 2019

@ykzts

ykzts approved these changes Mar 16, 2019

@Gargron Gargron merged commit 1c113fd into master Mar 16, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@ykzts ykzts deleted the feature-manage-followers branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.