Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show timeline preview or directory widgets if they are disabled #10284

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Mar 15, 2019

No description provided.

@Gargron

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

I'm not convinced why

@ThibG ThibG force-pushed the ThibG:fixes/landing-page-fixes branch from b328b8f to 5971c9b Mar 15, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 15, 2019

(Removing the closed messages commit from this, it's still WiP and another subject entirely)

Well, I find it only confusing. Also, the directory still shows users who opted in even if the feature has been disabled.

@Gargron

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Also, the directory still shows users who opted in even if the feature has been disabled.

Technically, it doesn't show the users, it shows the avatars--and I think even if the directory cannot be browsed, it's not a bad detail to convince the reader that there are people on the server (not a "ghost town").

I understand that being greyed out as an indicator for being disabled is perhaps not a fully intuitive thing, but maybe there are ways to adjust the "disabled" design to make it more obvious. (The "disabled" cursor on mouse-over, for example?)

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 15, 2019

I'm still not sure what is the benefit of showing a feature that's not enabled.
I guess I could understand if it was some kind of checklist of features the instance offers to a logged in user, but that's not the case.

@ThibG ThibG force-pushed the ThibG:fixes/landing-page-fixes branch from 5971c9b to ee8d97e Mar 18, 2019
@Gargron Gargron merged commit d041b7a into tootsuite:master Mar 19, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.