Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove stats.json generation in webpack #10290

Merged
merged 2 commits into from Mar 16, 2019

Conversation

@nolanlawson
Copy link
Collaborator

commented Mar 16, 2019

This makes it so webpack's BundleAnalyzerPlugin doesn't output a stats.json file.

By my measure, this reduces the time for asset precompilation from 71s to 53s, an 18s improvement. (I took the median of 5 runs to be sure, see raw results below.)

stats.json is only useful for tools like webpack analyse and webpack visualizer, and I'll bet nobody was looking at these.

click for raw results
before

1m12.509s
1m11.164s
1m16.499s
1m7.246s
1m6.841s

after

0m55.038s
0m52.712s
1m3.872s
0m52.329s
0m52.770s
nolanlawson added 2 commits Mar 16, 2019

@Gargron Gargron merged commit d5c7997 into master Mar 16, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@ykzts ykzts deleted the nolan/remove-stats-json branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.