Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and import `hide_notifications` alongside user mutes #10335

Merged
merged 3 commits into from Apr 3, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Mar 21, 2019

No description provided.

@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch 3 times, most recently from b2b59ad to 3cabbb1 Mar 21, 2019
@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch 5 times, most recently from 4402645 to 8a59546 Mar 21, 2019
@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch from 8a59546 to a0df95c Mar 21, 2019
@ThibG ThibG marked this pull request as ready for review Mar 21, 2019
@Gargron

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

I am concerned that this is a pandora's box because we also have follows with/without reblogs and whatnot. So far the CSV files were just lists of strings, very simple and understandable, now we are putting unexplained booleans in them. Maybe this should require the introduction of a header row.

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 28, 2019

Ah, yes, we could add a header, that would also help with potential future changes.
We need to be careful to chose header names that might not be interpreted as usernames by older versions though

@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch 6 times, most recently from 94449e7 to d73586d Mar 29, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 29, 2019

Well, I'm afraid I have no idea why the test fails on 2.4 and 2.5 but not 2.6.

@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch from d73586d to d3e42bb Mar 29, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 29, 2019

It appears it's a bug in the CSV module in older versions of Ruby when involving both headers and empty lines 😩
I modified the test suite to not have such empty lines…

@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch 3 times, most recently from 905686c to 0c4ac4f Mar 30, 2019
@ThibG ThibG force-pushed the ThibG:fixes/export-hide_notifications branch from 0c4ac4f to 44c6fa3 Mar 31, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 31, 2019

Updated to use more natural-looking headers such as “Account address” instead of “#account”

@Gargron
Gargron approved these changes Apr 3, 2019
@Gargron Gargron merged commit d4882aa into tootsuite:master Apr 3, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…e#10335)

* Export hide_notifications along with user mutes

* Import hide_notifications along with muted users list

* Add headers for CSV exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.