Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign profile column in web UI to match design on public pages #10337

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 21, 2019

image

Design notes

  • Square avatars (common complaint that they had a shape inconsistent with the rest of the interface)
  • Although I do miss the bouncy corners animation, that was sweet
  • Header image no longer obscured by everything else
  • Big obvious action button, instead of grey icon button that was blending with the backround
  • Also further away from the back button
  • Username now always showing full address even if local

@Gargron Gargron added the ui Front-end, design label Mar 21, 2019
@trwnh
Copy link
Member

trwnh commented Mar 21, 2019

the only thing i can suggest is to consider making the avatar not overlap the header (for consistency with the profile cards shown on following/followers pages), but i'm fine with it either way.

@ClearlyClaire
Copy link
Contributor

Overall this seems good, but I'm not super satisfied with the Toots / Follows / Followers stuff, which doesn't look super nice nor feels like tabs/buttons?

@Gargron
Copy link
Member Author

Gargron commented Mar 21, 2019

the only thing i can suggest is to consider making the avatar not overlap the header (for consistency with the profile cards shown on following/followers pages), but i'm fine with it either way.

That's what I started with but it leads to either massive wasted space in the middle, or a pretty small avatar to be the same height as the buttons. I imagine people want to see what's on the avatar when they open a profile.

@Gargron
Copy link
Member Author

Gargron commented Mar 21, 2019

Overall this seems good, but I'm not super satisfied with the Toots / Follows / Followers stuff, which doesn't look super nice nor feels like tabs/buttons?

It is what we've had on the public pages for a while.

Maybe making the entire text bolder would improve them?

@Aditoo17
Copy link
Contributor

You might also want to make the avatar on public pages square, to be consistent.

@ClearlyClaire
Copy link
Contributor

I mean, on the public pages, it looks like that, and I find it's way better?
Screenshot_2019-03-22 Eugen ( Gargron mastodon social)

@Gargron
Copy link
Member Author

Gargron commented Mar 22, 2019

@ThibG Resize the window to mobile width

@ariasuni
Copy link
Contributor

ariasuni commented Mar 24, 2019

Shouldn’t the three dot button be to the right of the «Edit profile» one, for consistency with toots and compose column?

@Gargron Gargron requested a review from ykzts March 25, 2019 23:15
@Gargron Gargron merged commit a96181f into master Mar 25, 2019
@Gargron Gargron deleted the feature-web-ui-profiles branch March 25, 2019 23:36
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…stodon#10337)

* Redesign profile column in web UI to match design on public pages

* Make the tab links text bolder
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
…stodon#10337)

* Redesign profile column in web UI to match design on public pages

* Make the tab links text bolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants