Fix HTML validation

[ClearlyClaire]

A possible improvement would be to use fragment.errors to tell why validation failed.

[Gargron]

The error message from Nokogiri won't be localized, so I think it might be worthless to show it to the end-user.

[ClearlyClaire]

I think it's still worth showing, even if it's not localized. Most of the time, it will mostly consist of a tag name and a position, which people might understand even if they don't understand English. I think this is better than just telling them it's invalid without telling people why, which would be a really frustrating experience. Le 25 mars 2019 05:15:13 GMT+01:00, Eugen Rochko <notifications@github.com> a écrit :

…

Gargron commented on this pull request. > @@ -3,12 +3,16 @@ class HtmlValidator < ActiveModel::EachValidator def validate_each(record, attribute, value) return if value.blank? - record.errors.add(attribute, I18n.t('html_validator.invalid_markup')) unless valid_html?(value) + errors = html_errors(value) + unless errors.empty? + record.errors.add(attribute, I18n.t('html_validator.invalid_markup', error: errors.first.to_s)) The error message from Nokogiri won't be localized, so I think it might be worthless to show it to the end-user. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #10354 (review)

-- Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.