Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ActivityPub `@context` values depending on response #10378

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@Gargron
Copy link
Member

commented Mar 26, 2019

Fix #8078

Each serializer states which contexts it uses, and which context extensions. The only useful named context right now is security. As for context extensions, they are categorized by features/useful property groups.

The adapter then assembles a @context dynamically from this information.

With less stuff in the @context, it saves a little bit of bandwidth, a little bit of storage in Sidekiq queues when the JSON is used as job arguments, and the payloads become more readable (glance value).

@Gargron Gargron force-pushed the feature-omit-unused-contexts branch from 1084867 to 6eb7c82 Mar 26, 2019
Copy link
Collaborator

left a comment

I still do not understand how associations are supposed to propagate but

@Gargron Gargron force-pushed the feature-omit-unused-contexts branch 2 times, most recently from 605058c to d29d0c7 Mar 27, 2019
@nightpool nightpool self-requested a review Mar 27, 2019
@Gargron Gargron force-pushed the feature-omit-unused-contexts branch from d29d0c7 to f505bc9 Mar 27, 2019
@Gargron Gargron force-pushed the feature-omit-unused-contexts branch from f505bc9 to 3dfb366 Mar 27, 2019
@Gargron Gargron merged commit 11fe293 into master Mar 27, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@ykzts ykzts deleted the feature-omit-unused-contexts branch Mar 28, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.