Changes to tootctl statuses remove #11267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment for the part of query keeping statuses which have replies was incorrect, explaining the part of the query kept favourited statuses instead
|
Well, I'm not sure if the optimization thing is really an optimization since there's no index on that, hm… |
|
The rationale for boosts is that we probably aren't interested in boosts from people we aren't interested in anymore (no followers). Additionally, while current Mastodon versions will now reject them, Peertube used to forward every boost they received. |
|
Also, I don't think a blanket exemption for toots from followed users is very useful either… On the other hand, about things that get deleted and probably shouldn't, recent boosts of old toots will get affected too… |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ykzts
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status.localandStatus.urito check if toots are local instead of checking their authorThere are most definitely more optimizations possible, and I'd like whole threads to be cleaned instead of just the leaves. I am not too sure how to do that efficiently (maybe doing the query in descending order on the ids would help?)