Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LDSigning when AUTHORIZED_FETCH is set to true #11295

Conversation

ClearlyClaire
Copy link
Contributor

Otherwise, replies and toots through relays will still end up on blocked instances

@Gargron
Copy link
Member

Gargron commented Jul 14, 2019

Does the relay code check for signature before sending the payload? If not, it should. Likewise the reply forwarding bits.

Reply forwarding has become an important part of Mastodon, in that it really substantially improves the readability of conversations. While it's okay to disable it in authorized fetch mode while it's optional, if the long-term goal is making authorized fetch mode the default, we need to figure out how reply forwards could work without LD-Signatures.

@ClearlyClaire
Copy link
Contributor Author

It does check, and do not try to forward unsigned toots. That wouldn't be new behavior, that would be akin to receiving messages from pleroma (which does not LDSign anything).

Yes, reply forwarding is somewhat important, but LDSigning is not compatible with AUTHORIZED_FETCH

@Gargron
Copy link
Member

Gargron commented Jul 14, 2019

@ThibG No I mean on our (sending to relay) end.

@ClearlyClaire
Copy link
Contributor Author

ClearlyClaire commented Jul 14, 2019

Oh, I don't believe it does check them. Most relays handle that fine by wrapping it in an Announce, though (even if that's far less efficient than using LDSigning).

EDIT: If that was unclear, I'm talking about the code sending toots to relays, not the code forwarding replies: this code does check for signatures.

@Gargron Gargron merged commit 2f813b7 into mastodon:master Jul 15, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants