Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping of toot date when clicking spoiler button #11449

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

ariasuni
Copy link
Contributor

Fix the weird behavior you can see in this gif:

Peek 31-07-2019 02-53

The date of the toot moves 2px down and up uselessly when clicking the spoiler button.

@ClearlyClaire
Copy link
Contributor

This 2px margin was introduced by you in #10821
So the fix would probably be to somehow add that 2px margin when the toot is hidden as well

@ariasuni
Copy link
Contributor Author

I do not have the issue with the cut letters anymore, and I felt weird about adding a margin for that in the first place.

Can you confirm that letters aren’t cut anymore with:

.reply-indicator__content p:last-child, .status__content p:last-child {
    margin-bottom: 0;
}

and that my previous workaround is not necessary anymore?

@ClearlyClaire
Copy link
Contributor

I'm indeed unable to reproduce the issue fixed by #10821 without that rule, hmm

@Gargron Gargron merged commit c4043ba into mastodon:master Jul 31, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Fix jumping of toot date when clicking spoiler button

* Fix lint
@ariasuni ariasuni deleted the fix-jumping-toot-date branch June 25, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants