Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media editing modal #11563

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@Gargron
Copy link
Member

commented Aug 14, 2019

Move media description input to a modal and unite that modal with the focal point modal. Add a hint about choosing focal points, as well as a preview of a 16:9 thumbnail. Enable the user to watch the video next to the media description input.

image

Fix #8320
Fix #6713

@Gargron Gargron added the ui label Aug 14, 2019

Add media editing modal
Move media description input to a modal and unite that modal with
the focal point modal. Add a hint about choosing focal points, as
well as a preview of a 16:9 thumbnail. Enable the user to watch
the video next to the media description input.

Fix #8320
Fix #6713

@Gargron Gargron force-pushed the feature-media-edit-modal branch from 6cdc8f4 to e34fc9b Aug 14, 2019

@ykzts

ykzts approved these changes Aug 14, 2019

@Gargron Gargron merged commit 23f7afa into master Aug 14, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-media-edit-modal branch Aug 14, 2019

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

This is less than optimal on mobile
Screen Shot 2019-08-14 at 11 09 02

The preview text and image prevent you from seeing the image appropriately or clicking to set the focus point, and there's a scrollbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.