Add special alert for throttled requests #11677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Aug 26, 2019
ClearlyClaire
force-pushed
the
features/ui-show-throttled
branch
from
c0d538b
to
3c827ca
Compare
Gargron
reviewed
Aug 27, 2019
| @@ -23,23 +25,29 @@ export function clearAlert() { | |||
| }; | |||
| }; | |||
|
|
|||
| export function showAlert(title = messages.unexpectedTitle, message = messages.unexpectedMessage) { | |||
| export function showAlert(title = messages.unexpectedTitle, message = messages.unexpectedMessage, message_values = undefined) { | |||
There was a problem hiding this comment.
There is really no need for a default value if the default value is undefined, JavaScript doesn't care how many arguments you pass into a function, if you pass fewer the other ones are undefined.
Gargron
approved these changes
Aug 27, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Add special alert for throttled requests * Use an extra attribute instead of an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.