Add batch actions and categories to admin UI for custom emojis #11793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gargron
force-pushed
the
feature-custom-emoji-admin-categorization
branch
from
2f4f79c
to
137ef4e
Compare
ClearlyClaire
approved these changes
Sep 9, 2019
| .fields-group.fields-row__column.fields-row__column-6 | ||
| .input.string.optional | ||
| .label_input | ||
| = f.text_field :category_name, class: 'string optional', placeholder: t('admin.custom_emojis.create_new_category'), 'aria-label': t('admin.custom_emojis.create_new_category') |
There was a problem hiding this comment.
I think those would be better as a single field with autocompletion… that can be left for later though.
| redirect_to admin_custom_emojis_path(page: params[:page], **@filter_params) | ||
| def batch | ||
| @form = Form::CustomEmojiBatch.new(form_custom_emoji_batch_params.merge(current_account: current_account, action: action_from_button)) | ||
| @form.save |
There was a problem hiding this comment.
Shouldn't we have a flash message to tell the changes were processed?
| expect(response).to redirect_to admin_custom_emojis_path | ||
| expect(custom_emoji.reload).to have_attributes(disabled: true) | ||
| end | ||
| end |
There was a problem hiding this comment.
Specs that cover the same use case with the new actions should probably be written.
Gargron
force-pushed
the
feature-custom-emoji-admin-categorization
branch
from
137ef4e
to
3457c1f
Compare
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11402