Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deletes to preserve statuses in unresolved reports #11805

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@Gargron
Copy link
Member

commented Sep 11, 2019

Currently deletes first perform a soft-delete for immediate API feedback, and then perform a real delete in the background. This change makes it so that the background task keeps statuses that are attached to unresolved reports, as well as making account deletion preserve such statuses as well.

When any account action is performed (warning, disable, silence, suspend), resolve all unresolved reports about that account, except when the action is "none" and connected to a specific report ("mark as resolved"). Resolving a report will fully remove associated soft-deleted statuses.

There is also a refactor of SuspendAccountService to be more readable, since the options to that service have become increasingly confusing.

  • Preservation of soft-deleted statuses in unresolved reports
  • Immediate deletions through the admin interface
  • Clean-up of soft-deleted statuses through report resolving

@Gargron Gargron force-pushed the feature-keep-statuses-in-reports branch from d4d0af6 to a613a30 Sep 11, 2019

@Gargron Gargron changed the title Change deletes to not remove statuses in unresolved reports Change deletes to preserve statuses in unresolved reports Sep 11, 2019

@Gargron Gargron force-pushed the feature-keep-statuses-in-reports branch 3 times, most recently from 009854f to 02396a9 Sep 11, 2019

Change deletes to preserve soft-deleted statuses in unresolved reports
Change all account actions except "none" to resolve all unresolved reports

Refactor `SuspendAccountService` to be more readable

@Gargron Gargron force-pushed the feature-keep-statuses-in-reports branch from 02396a9 to 035c260 Sep 11, 2019

@Gargron Gargron marked this pull request as ready for review Sep 11, 2019

@ykzts
ykzts approved these changes Sep 11, 2019

@Gargron Gargron merged commit c5d37f1 into master Sep 11, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-keep-statuses-in-reports branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.