Change unlisted custom emoji to not appear in autosuggestions #11818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Sep 13, 2019
ClearlyClaire
approved these changes
Sep 13, 2019
|
How are unlisted emoji supposed to be discovered, then? |
|
At least two different admins from different servers showed confusion about the previous behaviour. It seems like unlisted emoji are not supposed to be discovered. The main practical difference between an emoji being disabled and unlisted is that a disabled emoji will not render, while an unlisted will. The use case of unlisted emoji is therefore:
|
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Siphonay
added a commit
to Siphonay/mastodon
that referenced
this pull request
Jan 2, 2020
…mastodon#11818)" This reverts commit 59da5cc.
Siphonay
added a commit
to Siphonay/mastodon
that referenced
this pull request
Feb 4, 2022
…mastodon#11818)" This reverts commit 59da5cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11669