Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Move handler queuing jobs that will fail if account is suspended #11864

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@Gargron
Copy link
Member

Gargron commented Sep 16, 2019

  • If target account is suspended, exit early instead of queueing jobs that will fail / retry
  • Always set moved-to account in case it's a different than the one before
  • If Move handler could not execute, reset cooldown, to allow trying again
  • Do not unmerge old account from home timelines
Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
@Gargron Gargron force-pushed the fix-move-handler branch to 669372b Sep 16, 2019
@ykzts
ykzts approved these changes Sep 17, 2019
@Gargron Gargron merged commit 38dc51b into master Sep 17, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@Gargron Gargron deleted the fix-move-handler branch Sep 17, 2019
noellabo added a commit to noellabo/mastodon that referenced this pull request Sep 22, 2019
…ootsuite#11864)

Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…ootsuite#11864)

Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
katsusuke added a commit to katsusuke/mastodon that referenced this pull request Nov 26, 2019
…ootsuite#11864)

Don't put Move handler on cooldown if it didn't run. Skip unmerging
from timelines to save unnecessary work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.