Fix Move handler queuing jobs that will fail if account is suspended #11864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Sep 16, 2019
•
Gargron
commented
- If target account is suspended, exit early instead of queueing jobs that will fail / retry
- Always set moved-to account in case it's a different than the one before
- If Move handler could not execute, reset cooldown, to allow trying again
- Do not unmerge old account from home timelines
Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.
Gargron
force-pushed
the
fix-move-handler
branch
from
a12f711
to
669372b
Compare
ykzts
approved these changes
Sep 17, 2019
noellabo
pushed a commit
to noellabo/mastodon
that referenced
this pull request
Sep 22, 2019
…astodon#11864) Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…astodon#11864) Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.