Change conversations UI #11896
Merged
Change conversations UI #11896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-conversations-ui
branch
from
4716c32
to
cef691a
Compare
ClearlyClaire
approved these changes
Sep 21, 2019
|
|
||
| const handlers = { | ||
| reply: this.handleReply, | ||
| favourite: this.handleFavourite, |
There was a problem hiding this comment.
slightly weird to have a handler for that when there's nothing in the UI to show the fav state nor do it with something else than the keyboard shortcut
There was a problem hiding this comment.
Oh oops, it isn't hooked up to anything, actually. I'm not sure if the fav button should be there. Don't want it to look too similar to a status. It also doesn't fav the conversation, but the most recent status, so... Not sure.
There was a problem hiding this comment.
yeah, I think it's best without it at all (I notice that glitch-soc's slight redesign of the conversations UI has the same issue: no button—on purpose—but the handler is still on)
Gargron
force-pushed
the
feature-conversations-ui
branch
from
cef691a
to
ed9d46c
Compare
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
May 30, 2022
Leftover from before mastodon#11896
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
Leftover from before mastodon#11896
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
Leftover from before mastodon#11896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11414, fix #9860, fix #10434
There was a bug preventing showing more than 2 avatars. Now 4 avatars can be displayed at once, with anything extra marked with a number label on top. Every participant is listed above the DM individually, and each name is clickable. Attachments are always displayed in list form. The action bar now includes DM-specific items such as deleting the whole conversations or marking it as read (without opening). An option to mute the conversation is more prominent.
Resolve #11839