Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback section ID with ToC #11941

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Add fallback section ID with ToC #11941

merged 1 commit into from
Sep 23, 2019

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Sep 23, 2019

'日本語'.parameterize # -> ""

String#parameterize skips CJK strings. For CJK-only headings, the ID is empty. To address this, add a fallback string.

@Gargron Gargron merged commit 67bef15 into master Sep 23, 2019
@Gargron Gargron deleted the ykzts-patch-1 branch September 23, 2019 15:25
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants