Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast multipart threshold to integer #11944

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Cast multipart threshold to integer #11944

merged 1 commit into from
Sep 24, 2019

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Sep 24, 2019

No description provided.

@ykzts ykzts added the bug Something isn't working label Sep 24, 2019
Gargron
Gargron reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@Gargron Gargron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A header will be transmitted as string anyway. Perhaps you want the cast on the megabytes object?

@ykzts
Copy link
Sponsor Member Author

ykzts commented Sep 24, 2019

Yes, I thought so. However, this is handled as a number internally by aws-sdk-s3.

Also Numeric#megabytes returns Integer.

https://github.com/rails/rails/blob/v5.2.3/activesupport/lib/active_support/core_ext/numeric/bytes.rb#L30

@Gargron Gargron merged commit b02169f into master Sep 24, 2019
@Gargron Gargron deleted the to_i branch September 24, 2019 15:32
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@ykzts @hiyuki2578
Cast multipart threshold to integer (mastodon#11944)
865934f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ykzts @Gargron