✨ Add an LDAP Mail attribute config #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmath03
changed the title
madmath03
changed the title
Gargron
approved these changes
Dec 1, 2019
Gargron
changed the title
|
Sorry for the delay. Please rebase. |
|
Hi @Gargron, No problem. |
|
The changeset is now very large, I'm worried something else might get reverted by accident if I merge. Could you please do |
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
madmath03
force-pushed
the
feature/ldap_mail
branch
from
12fc8b7
to
fe0f619
Compare
|
My bad. |
Gargron
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Add an LDAP Mail attribute config
This is just a small improvement that allows to set the LDAP mail attribute.
Also, I suggest a default search filter that allows LDAP users to login from their UID or their email address (just like internal users).