Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change media description label to be context-sensitive #12270

Merged

Conversation

@ThibG
Copy link
Collaborator

ThibG commented Oct 31, 2019

This PR changes the text to be:

  • “Describe for the visually impaired” (the current text) for images and video without sound
  • “Describe for people with hearing loss” for audio files
  • “Describe for people with hearing loss or visual impairment” for video files with sound

I am not sure they are the best labels, but they definitely make more sense than having “Describe for the visually impaired” for audio-only uploads. Arguably, describing media isn't only for people with any kind of impairment, it also covers use cases where the person cannot enjoy the media at the moment for external factors.

Alternatively, we could have a generic label.

“Describe for the visually impaired” makes no sense when the uploaded media
is an audio file.
@ThibG ThibG requested a review from Gargron Nov 20, 2019
@Gargron Gargron merged commit e86234b into tootsuite:master Nov 21, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.