Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change audio/video playback to stop playback when out of view #12486

Merged
merged 1 commit into from Jan 11, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 26, 2019

  • Change video player to not loop, since the audio player doesn't
  • Change playback and mute buttons to feel snappier

@Gargron Gargron added the ui Front-end, design label Nov 26, 2019
@ClearlyClaire
Copy link
Contributor

I personally would oppose to this for two main reasons:

  • actually, I prefer media to keep playing when scrolling, especially when it's mostly audio and I'm in a thread view. I hate what Twitter does in that regard
  • this would be inconsistent with media from preview cards, which we can't control… (well, we could unload them completely, but I'd find it even more annoying)

@Gargron
Copy link
Member Author

Gargron commented Nov 27, 2019

The intersection observer or the reducer do unload the media when it's scrolled away, it's just not immediate. I feel like this way is cleaner, makes it a more consistent behaviour than "keep scrolling and at some point it'll just stop playback, or maybe not until new toots come in from top"

Change video player to not loop, since the audio player doesn't

Change playback and mute buttons to feel snappier
@Gargron Gargron force-pushed the fix-stop-video-playback-on-scroll-away branch from 1bb8d63 to 117b46c Compare November 30, 2019 18:42
@Gargron Gargron merged commit baa3db3 into master Jan 11, 2020
@Gargron Gargron deleted the fix-stop-video-playback-on-scroll-away branch January 11, 2020 01:03
umonaca added a commit to umonaca/mastodon that referenced this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants