Fix batch actions on non-pending tags in admin interface #12537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow batch actions on unreviewed tags - Hide checkboxes when batch actions aren't available
ClearlyClaire
force-pushed
the
fixes/hashtag-bash-actions
branch
from
50b0d4a
to
9439de7
Compare
|
oops, I had inadvertently added a temporary file. Removed it and rebased the PR |
ykzts
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Hashtag admin page shows batch action checkboxes on every page but only actually show action buttons on the “pending review” tab. This is confusing and unnecessary, and frustrating when one checks every tag then figures out they can't act on them.
This PR changes that to:
I wonder about that last part: should we allow to override the state even for reviewed tags? If so we could just show the batch actions in all cases.