Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample SAML_ACS_URL, SAML_ISSUER #12669

Merged
merged 1 commit into from Dec 23, 2019
Merged

Conversation

@orlea
Copy link
Contributor

orlea commented Dec 23, 2019

The values of SAML_ACS and SAML_ISSUER in the sample .env file are strange.

"http://localhost:3000/auth/auth/saml/callback" should be written as a sample value for SAML_ACS.

In addition, since SAML_ISSUER is a unique value representing the service provider, it is better to enter a domain name unless otherwise specified by IdP.

When actually setting up SAML, the user needs to overwrite it, so it gets confused if strange values are listed.
Thankyou!

@Gargron Gargron merged commit 44f88a3 into tootsuite:master Dec 23, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@orlea orlea deleted the orlea:Fix-sample-env-files branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.