-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate cache directory for non-local uploads #12821
Conversation
5fac572
to
d85a6be
Compare
fb2a573
to
d073d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very welcome change overall, although I have some minor concerns (see inline comments).
5203795
to
a19fb36
Compare
a19fb36
to
397e517
Compare
397e517
to
235d68d
Compare
This seems to have broken path to existing icons and custom emojis. E.g., my avatar which has been t https://s3.amazonaws.com/zundan-mastodon/accounts/avatars/000/000/001/original/89de63b40ca41c7e.gif is now rendered as https://s3.amazonaws.com/zundan-mastodon/system/accounts/avatars/000/000/001/original/89de63b40ca41c7e.gif_prefixaccounts/avatars/000/000/001/original/89de63b40ca41c7e.gif
|
This issue also occurs in my environment using Ruby 2.6.6 with OpenStack Swift. |
This seems to fix it, but I don't understand why this problem occurs... |
The following resources will be split into a top-level cache directory:
...when they don't originate from local accounts. With the exception of preview cards, which are always counted as not local. The change comes into effect for anything uploaded or downloaded after the upgrade, old files remain in place, so as to not incur massive object storage costs moving potentially terabytes of data.
Adds
tootctl upgrade storage-schema
to upgrade all existing files at once.