Fix non-x64 architectures not being able to build Docker image because of hardcoded Node.js architecture #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| @@ -5,14 +5,24 @@ SHELL ["bash", "-c"] | |||
|
|
|||
| # Install Node v12 (LTS) | |||
| ENV NODE_VER="12.14.0" | |||
| RUN echo "Etc/UTC" > /etc/localtime && \ | |||
| RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
There was a problem hiding this comment.
Suggested change
| RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |
| RUN ARCH= && \ | |
| dpkgArch="$(dpkg --print-architecture)" \ |
Dockerfile
Outdated
| @@ -5,14 +5,24 @@ SHELL ["bash", "-c"] | |||
|
|
|||
| # Install Node v12 (LTS) | |||
| ENV NODE_VER="12.14.0" | |||
| RUN echo "Etc/UTC" > /etc/localtime && \ | |||
| RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
| && case "${dpkgArch##*-}" in \ | |||
There was a problem hiding this comment.
the && should go to the line above
ClearlyClaire
approved these changes
Feb 14, 2020
Gargron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13055
This allows building on raspberry pi.