Fix error within error when limiting backtrace to 3 lines #13120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Feb 20, 2020
ClearlyClaire
approved these changes
Feb 20, 2020
zunda
reviewed
Mar 1, 2020
| def call(*) | ||
| yield | ||
| rescue Mastodon::HostValidationError | ||
| # Do not retry | ||
| rescue => e |
There was a problem hiding this comment.
For the Code Climate error "Avoid rescuing without specifying an error class.", we might be able to start rescueing the following exceptions that have been recorded on my server in the last 24 hours:
- HTTP::ConnectionError
- HTTP::TimeoutError
- Mastodon::UnexpectedResponseError
- Stoplight::Error::RedLight (this might go elsewhere with the change in this PR)
zunda
added a commit
to zunda/mastodon
that referenced
this pull request
May 9, 2020
This should be an improved version from mastodon#13113 with a specific list of exceptions to be caught created from mastodon#13120 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution within Sidekiq middleware to be more DRY
Fix #13086, close #13113