Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account aliases page #13452

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Fix account aliases page #13452

merged 2 commits into from
Apr 13, 2020

Conversation

ClearlyClaire
Copy link
Contributor

  • Fix errors not being displayed under the “Handle of the old account” field
  • Add clearer error messages
  • Add error case when adding an alias to the same account
  • Make the empty list show “You have no aliases.”

image
image
image

ClearlyClaire and others added 2 commits April 12, 2020 19:35
@ClearlyClaire @ariasuni
Fix error not being displayed when adding an account alias, add error…
ba1cf42 
… for self-references

Co-Authored-By: Mélanie Chauvel (ariasuni) <perso@hack-libre.org>
@ClearlyClaire @ariasuni
Add “You have no aliases.” note in confusing empty aliases table
b7a52f2 
Co-Authored-By: Mélanie Chauvel (ariasuni) <perso@hack-libre.org>
@Gargron Gargron merged commit f7e0119 into mastodon:master Apr 13, 2020
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Apr 15, 2020
@ClearlyClaire
Fix confusing error when failing to add an alias to an unknown account
ed1e211 
Follow-up to mastodon#13452, fixing broken `uri.nil?` test.

Also remove the separate check for `uri` presence, as that would result
in a “Please review 2 errors below” while only one would be listed.
@ClearlyClaire ClearlyClaire mentioned this pull request Apr 15, 2020
Merged
Gargron pushed a commit that referenced this pull request Apr 15, 2020
@ClearlyClaire
Fix confusing error when failing to add an alias to an unknown account (
3825e19 
#13480)

Follow-up to #13452, fixing broken `uri.nil?` test.

Also remove the separate check for `uri` presence, as that would result
in a “Please review 2 errors below” while only one would be listed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClearlyClaire @ykzts @Gargron