Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to use a users preferred theme on public pages #13471

Closed
wants to merge 2 commits into from
Closed

add ability to use a users preferred theme on public pages #13471

wants to merge 2 commits into from

Conversation

lfuelling
Copy link
Contributor

Hi,
this PR adds a user preference where the user can decide to show the theme set in their account settings on their public profile page and their public status pages.

In case the setting is not set, the default theme (either a logged in users selected theme or the default instance theme) will be shown.

…us page

 Conflicts:
	app/controllers/settings/preferences_controller.rb
	app/lib/user_settings_decorator.rb
	app/models/user.rb
	app/serializers/initial_state_serializer.rb
	app/views/settings/preferences/appearance/show.html.haml
	config/locales/simple_form.en.yml
	spec/lib/settings/scoped_settings_spec.rb
@lfuelling
Copy link
Contributor Author

If you have any suggestion on how to fix the rubocop issue, let me know.
I'd consider it a false positive beacuse splitting the method up wouldn't make it prettier...

@SuperSandro2000
Copy link
Contributor

Rubocop just thinks the function is to complex.

@lfuelling
Copy link
Contributor Author

lfuelling commented May 7, 2020

If you want/need an example of this, @ffffound uses the "mastodon-dark" theme while the default instance theme is a custom one.

@lfuelling lfuelling closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants