Fix uploaded image orientation in some browsers #13493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
added
the
browser compatibility
ClearlyClaire
force-pushed
the
fixes/chrome-image-orientation
branch
from
ee55fc5
to
b96450a
Compare
Some browsers (at least recent Chrome versions) automatically take image metadata into account when drawing images into a canvas. There seem to be no way to prevent that behavior, and the only way to detect it seems to compare with a known image. See: w3c/csswg-drafts#4666 Solution adapted from: blueimp/JavaScript-Load-Image@1e4df70
ClearlyClaire
force-pushed
the
fixes/chrome-image-orientation
branch
from
b96450a
to
06dc83d
Compare
Gargron
approved these changes
Apr 18, 2020
|
Maybe we should strip exif data when uploading images? |
|
EXIF data is stripped by the server. The code in question runs before the upload. |
|
Thanks for tagging me @ThibG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browsers (at least recent Chrome versions) automatically take
image metadata into account when drawing images into a canvas.
There seem to be no way to prevent that behavior, and the only
way to detect it seems to compare with a known image.
See: w3c/csswg-drafts#4666
Solution adapted from: blueimp/JavaScript-Load-Image@1e4df70 (my understanding is that it's fine for us to reuse that code this way, it being licensed under MIT, but tagging @blueimp nevertheless just in case)