Remove confusing “You are already signed in.” flash message #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/already-signed-in-flash-message
branch
from
7935484
to
1f8abb1
Compare
When attempting to access the log-in page while already logged in, Devise's `require_no_authentication` kicks in and sets a flash message “You are already signed in.” In almost all cases, this also causes a redirect to /web, which does not display or clear flash messages, thus leaving the message to a potentially much later date, like for instance, accessing /preferences several minutes after being redirected to /web.
ClearlyClaire
force-pushed
the
fixes/already-signed-in-flash-message
branch
from
1f8abb1
to
e127e5f
Compare
Gargron
reviewed
Apr 27, 2020
| @@ -111,6 +111,13 @@ def prompt_for_two_factor(user) | |||
| render :two_factor | |||
| end | |||
|
|
|||
| def require_no_authentication | |||
| super | |||
There was a problem hiding this comment.
What does the upstream method do? Does it make sense to super instead of just doing what it does without the thing we don't want?
There was a problem hiding this comment.
It does some more low-level checks to see if a user is logged in, and, if that's the case, redirects to after_sign_in_path_for and sets the flash message.
I thought about the two following alternatives:
- do that in
after_sign_in_path_forinstead, but doing anything effectful in there seems weird - rewrite
require_no_authenticationentirely, but I'm a bit uncomfortable with that as it is lower-level Devise/warden stuff
Gargron
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to access the log-in page while already logged in,
Devise's
require_no_authenticationkicks in and sets a flashmessage “You are already signed in.”
In almost all cases, this also causes a redirect to /web, which
does not display or clear flash messages, thus leaving the message
to a potentially much later date, like for instance, accessing
/preferences several minutes after being redirected to /web.