Fix/14021 behaviour on add or remove toots #14212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Gargron, can you take a look at this? |
Gargron
approved these changes
Jul 19, 2020
|
@Gargron When the reply notification is received by WebUI while displaying the account timelime on the latest master, the display of the notification column becomes strange. |
|
Could you be more specific about what was the strange behavior and how to reproduce it? |
Gargron
reviewed
Jul 23, 2020
| @@ -73,6 +75,12 @@ class AccountTimeline extends ImmutablePureComponent { | |||
| this.props.dispatch(expandAccountTimeline(accountId, { withReplies })); | |||
| } | |||
|
|
|||
| componentDidMount () { | |||
| if (this.props.params.accountId === me) { | |||
| this.disconnect = this.props.dispatch(connectUserTimelineStream(me)); | |||
There was a problem hiding this comment.
I've just realized this should not be necessary because the user stream is always active, it starts when the app is opened.
Gargron
added a commit
that referenced
this pull request
Jul 24, 2020
…e in web UI Fix regression from #14212
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
* Add toot send by current user at local state after send a new toot Related to mastodon#14021 * Decrement toot counter at profile when remove a toot Related to mastodon#14021 * Remove semicolon at end of line
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
…e in web UI (mastodon#14387) Fix regression from mastodon#14212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as @bluescreen69 exhibited at #14021 when a new Toot is added at your own account timeline it is not showed unless the page is reloaded also when a Toot is removed at the same screen the toot counter is not updated.
Thus my PR pretends to solve both of these items. Some changes were made at JS code and one line was added to Rails code. I am very newbie in RnR so any comments are welcome.