Fix new accent color not refreshing when changing thumbnail for audio uploads #14264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
Jul 8, 2020
| @@ -103,7 +103,7 @@ class Audio extends React.PureComponent { | |||
| } | |||
|
|
|||
| componentDidUpdate (prevProps, prevState) { | |||
| if (prevProps.src !== this.props.src || this.state.width !== prevState.width || this.state.height !== prevState.height) { | |||
| if (prevProps.src !== this.props.src || this.state.width !== prevState.width || this.state.height !== prevState.height || prevProps.accentColor !== this.props.accentColor) { | |||
There was a problem hiding this comment.
Hmm I suppose this needs take background and foreground colors into account too.
There was a problem hiding this comment.
Nope, those are properly passed down, and not part of the canvas.
There was a problem hiding this comment.
Wait, we should just make a poster check. The colors can't change unless the poster image changed.
There was a problem hiding this comment.
Oh right, only accentColor gets drawn currently. I see what you mean now. Yeah this makes sense then.
Gargron
requested changes
Jul 8, 2020
| @@ -103,7 +103,7 @@ class Audio extends React.PureComponent { | |||
| } | |||
|
|
|||
| componentDidUpdate (prevProps, prevState) { | |||
| if (prevProps.src !== this.props.src || this.state.width !== prevState.width || this.state.height !== prevState.height) { | |||
| if (prevProps.src !== this.props.src || this.state.width !== prevState.width || this.state.height !== prevState.height || prevProps.accentColor !== this.props.accentColor) { | |||
There was a problem hiding this comment.
Wait, we should just make a poster check. The colors can't change unless the poster image changed.
Gargron
approved these changes
Jul 8, 2020
abcang
pushed a commit
to abcang/mastodon
that referenced
this pull request
Jul 11, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The props are correctly passed down to the audio player, but the canvas doesn't get redrawn unless it is currently playing.
This PR changes that.