Freeze scroll position when a dropdown menu is open in the TL #14271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm this is useful but I'm wrong, it doesn't fix #14266, as that's the “scroll to compensate” that causes the issue in single-column mode in the first place. |
|
@ThibG wrong GIF in the description? 👀 |
Indeed 😩 |
Gargron
approved these changes
Jul 9, 2020
abcang
pushed a commit
to abcang/mastodon
that referenced
this pull request
Jul 11, 2020
…on#14271) * Freeze scroll position when a dropdown menu is open in the TL * Apply this to direct TL as well * Fix case when mouse leaves the menu
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
…on#14271) * Freeze scroll position when a dropdown menu is open in the TL * Apply this to direct TL as well * Fix case when mouse leaves the menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we do change the dropdown code to be
position: fixedto fix the issue with single-column mode, it still makes sense to freeze TL scrolling to avoid the dropdown menu pointing at something different than the status it was originally open for.I am not completely happy with using react-redux's
connectinScrollableListas it's a component, but that wouldn't be a first (e.g.,StatusActionBar).