Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve group processing #14279

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Conversation

noellabo
Copy link
Contributor

@noellabo noellabo commented Jul 10, 2020

Delivery from group actors is highly compatible with the method of using announce activity, but inefficient. Add the ability to accept an LD-signed create activity relayed by a group actor and fan-out it.

  • Changed so that the server accepts create activities when the user is following the actor who performs proxy delivery.
  • Fixed a bug that the follower collection of group was not expanded when a local group actor was specified as the destination. (However, there is still no way to create a local group actor)
  • When a post comes from a group that the user is following, it will be delivered to the followers of the group.

I've rewritten it so that it will be delivered to the followers of the post and the followers of the mentioned group without duplication. Please review if it works properly.

Change:

  • All deliveries to followers will be made by Announce from group actors to identify posts from group members.
  • Suppress fetch by Announce by caching in advance by Create Activity.

@Gargron Gargron merged commit 5c23ec2 into mastodon:master Jul 14, 2020
shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request Dec 7, 2022
* Fix the local group's followers collection

* Fix to accept followed relayed_through_account

* Add local delivery to the group's followers

* Fix code style

* Revert "Add local delivery to the group's followers"

This reverts commit 3237eff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants